[FFmpeg-devel] [PATCH 1/2] matroskaenc: Add CuePoints for subtitle tracks

[Michael Niedermayer]

On Thu, Sep 19, 2013 at 08:21:16PM -0300, James Almer wrote:
> On 19/09/13 7:11 PM, Michael Niedermayer wrote:
> > On Sat, Sep 14, 2013 at 05:59:21AM -0300, James Almer wrote:
> >>
> >> Signed-off-by: James Almer <jamrial at gmail.com>
> >> ---
> >>  libavformat/matroskaenc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Do these 2 patches fix/improve playback/seeking with some software?
> > If so please put this information in the commit message
> > and also explain how the issue and fix can be reproduced if you
> > have a testcase
> 
> I don't know if any software currently reads and uses cues for subtitle tracks, 
> and considering how new the cueduration element is i doubt any software reads 
> them either.
> I'm essentially replicating mkvtoolnix muxing practices with this. Afaik, with 
> proper demuxer/splitter support, the idea of having a cueduration entry in 
> subtitle cue points is to improve the display of subtitles right after seeking 
> to a given point in the stream.

if you say this matches existing practice then its ok

first patch applied
second seems not to apply anymore

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130920/4497808f/attachment.asc>