[FFmpeg-devel] [PATCH]Support pal8 in x11grab
george at nsup.org
Wed Oct 23 18:39:17 CEST 2013
Le duodi 2 brumaire, an CCXXII, Ronald S. Bultje a écrit :
> This is mostly a concern for portable devices (think phones) or otherwise
> limited environments, and it's questionable as for whether this particular
> feature (xgrab) would be of much use in such an environment anyway. (It's
> like worrying about Visual Studio-related compiler issues in the
> video4linux avdevice.)
> But a typical bad value on such a device would be a MB or more, and a
> typical OK value would be a kB or less. Anything in between should probably
> be considered on its own merit, with higher being less likely to be OK and
> less to be more likely to be OK (e.g. let's say 16-64kB is probably a
> sensible limit, but 256kB might be OK in some situations).
I agree with this analysis.
For reference, a quick grep shows a few 32-64k local arrays, and quite a few
2-8k. This one is 3k on 32-bits and 4k on 64-bits because nobody thought to
fix Xlib's API not to use longs, so it should not be a problem.
Also, if you take care to ensure that the array is only in scope when
necessary (possibly moving the related code in a separate function), then it
can not cause a regression anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
More information about the ffmpeg-devel