[FFmpeg-devel] [PATCH]Support pal8 in x11grab

[Ronald S. Bultje]

Hi,

On Wed, Oct 23, 2013 at 10:37 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> Michael Niedermayer <michaelni <at> gmx.at> writes:
>
> > On Wed, Oct 23, 2013 at 01:59:27PM +0000, Carl Eugen Hoyos wrote:
> > > Michael Niedermayer <michaelni <at> gmx.at> writes:
> > >
> > > > XColor color[256]
> > > > would avoid the malloc, cheking and free
> > >
> > > What is a sensible limit?
> >
> > limit of what ?
>
> I meant what is the sensible limit for allocations
> on the stack (I remember some were removed in the past)?


This is mostly a concern for portable devices (think phones) or otherwise
limited environments, and it's questionable as for whether this particular
feature (xgrab) would be of much use in such an environment anyway. (It's
like worrying about Visual Studio-related compiler issues in the
video4linux avdevice.)

But a typical bad value on such a device would be a MB or more, and a
typical OK value would be a kB or less. Anything in between should probably
be considered on its own merit, with higher being less likely to be OK and
less to be more likely to be OK (e.g. let's say 16-64kB is probably a
sensible limit, but 256kB might be OK in some situations).

HTH,
Ronald