[FFmpeg-devel] [PATCH 2/2] ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.

Michael Niedermayer michaelni at gmx.at
Thu Oct 3 16:08:35 CEST 2013


On Thu, Oct 03, 2013 at 01:24:52PM +0100, Derek Buitenhuis wrote:
> On 10/1/2013 5:45 PM, Michael Niedermayer wrote:
> >> Shouldn't this be changed to 1, since after this patch, we consider it
> >> an error (as per the user's settings)?
> > 
> > my thought was to use distinct error codes to allow a user to
> > identify why a error happened but iam fine with anything that
> > people prefer ...
> 
> Non-standard (not 1 or 0) exit codes make using ffmpeg pragmatically quite
> a pain.
> 
> >>> @@ -2709,6 +2710,8 @@ const OptionDef options[] = {
> >>>          "extract an attachment into a file", "filename" },
> >>>      { "debug_ts",       OPT_BOOL | OPT_EXPERT,                       { &debug_ts },
> >>>          "print timestamp debugging info" },
> >>> +    { "max_error_rate",  HAS_ARG | OPT_FLOAT,                        { &max_error_rate },
> >>> +        "maximum error rate", "rate between 0.0 and 1.1" },
> >>
> >> What does this range represent? Should be added to the message.
> > 
> > fixed
> > -        "maximum error rate", "rate between 0.0 and 1.1" },
> > +        "maximum error rate", "ratio of errors from 0.0 to 1.1 above which ffmpeg returns an error instead of 0." },
> 
> ... so what ARE 0.0 and 1.1? 1.1 errors per second? 1.1 errors? 1.1 magic pixies?

the idea was that 0 means 0% and 1 means 100% where 1 would still
accept cases that had 1 successfully decoded frame and above 1 would
accept even 0 successfully decoded frames

but ive simplified it so it doesnt need >1 values

commit 43221418e4f0ae970ab4b05fe99ee7099d84a89c
Author: Michael Niedermayer <michaelni at gmx.at>
Date:   Tue Oct 1 18:17:16 2013 +0200

    ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.

    Suggested-by: Daemon404
    Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

diff --git a/ffmpeg.c b/ffmpeg.c
index d1c841f..101813f 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -3420,7 +3420,7 @@ int main(int argc, char **argv)
     }
     av_log(NULL, AV_LOG_DEBUG, "%"PRIu64" frames successfully decoded, %"PRIu64" decoding errors\n",
            decode_error_stat[0], decode_error_stat[1]);
-    if (2*decode_error_stat[0] < decode_error_stat[1])
+    if ((decode_error_stat[0] + decode_error_stat[1]) * max_error_rate < decode_error_stat[1])
         exit_program(69);

     exit_program(received_nb_signals ? 255 : 0);
diff --git a/ffmpeg.h b/ffmpeg.h
index 09b29a9..054e718 100644
--- a/ffmpeg.h
+++ b/ffmpeg.h
@@ -420,6 +420,7 @@ extern int qp_hist;
 extern int stdin_interaction;
 extern int frame_bits_per_raw_sample;
 extern AVIOContext *progress_avio;
+extern float max_error_rate;

 extern const AVIOInterruptCB int_cb;

diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c
index a542b8d..247d3b0 100644
--- a/ffmpeg_opt.c
+++ b/ffmpeg_opt.c
@@ -84,6 +84,7 @@ int print_stats       = -1;
 int qp_hist           = 0;
 int stdin_interaction = 1;
 int frame_bits_per_raw_sample = 0;
+float max_error_rate  = 2.0/3;


 static int intra_only         = 0;
@@ -2717,6 +2718,8 @@ const OptionDef options[] = {
         "extract an attachment into a file", "filename" },
     { "debug_ts",       OPT_BOOL | OPT_EXPERT,                       { &debug_ts },
         "print timestamp debugging info" },
+    { "max_error_rate",  HAS_ARG | OPT_FLOAT,                        { &max_error_rate },
+        "maximum error rate", "ratio of errors (0.0: no errors, 1.0: 100% errors) above which ffmpeg returns an error instead of success." },

     /* video options */
     { "vframes",      OPT_VIDEO | HAS_ARG  | OPT_PERFILE | OPT_OUTPUT,           { .func_arg = opt_video_frames },



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131003/34803c9c/attachment.asc>


More information about the ffmpeg-devel mailing list