[FFmpeg-devel] [PATCH 2/2] ffmpeg: add max_error_rate to allow tuning the point decoding errors are considered a failure of the whole transcoding.

[Derek Buitenhuis]

On 10/1/2013 5:45 PM, Michael Niedermayer wrote:
>> Shouldn't this be changed to 1, since after this patch, we consider it
>> an error (as per the user's settings)?
> 
> my thought was to use distinct error codes to allow a user to
> identify why a error happened but iam fine with anything that
> people prefer ...

Non-standard (not 1 or 0) exit codes make using ffmpeg pragmatically quite
a pain.

>>> @@ -2709,6 +2710,8 @@ const OptionDef options[] = {
>>>          "extract an attachment into a file", "filename" },
>>>      { "debug_ts",       OPT_BOOL | OPT_EXPERT,                       { &debug_ts },
>>>          "print timestamp debugging info" },
>>> +    { "max_error_rate",  HAS_ARG | OPT_FLOAT,                        { &max_error_rate },
>>> +        "maximum error rate", "rate between 0.0 and 1.1" },
>>
>> What does this range represent? Should be added to the message.
> 
> fixed
> -        "maximum error rate", "rate between 0.0 and 1.1" },
> +        "maximum error rate", "ratio of errors from 0.0 to 1.1 above which ffmpeg returns an error instead of 0." },

... so what ARE 0.0 and 1.1? 1.1 errors per second? 1.1 errors? 1.1 magic pixies?

- Derek