[FFmpeg-devel] [PATCH] Handling special characters in a URL.

[Michael Niedermayer]

On Thu, Mar 07, 2013 at 12:39:01AM +0530, Senthilnathan Maadasamy wrote:
> On Tue, Mar 5, 2013 at 11:57 AM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> 
> > On 5 Mar 2013, at 05:00, Senthilnathan Maadasamy <
> > senthilnathan.maadasamy at gmail.com> wrote:
> >
> > > On Mon, Mar 4, 2013 at 7:49 PM, Michael Niedermayer <michaelni at gmx.at
> > >wrote:
> > >
> > >> On Mon, Mar 04, 2013 at 06:30:03AM +0530, Senthilnathan Maadasamy
> > wrote:>
> > >> +    while (len < component_size && (c = src[len])) {
> > >>
> > >>> +        if (isalnum(c) || strchr("-._~%", c) ||
> > >>
> > >> isalnum is locale specific
> > >
> > > Fixed it in the attached patch.
> > > <special-characters-in-URL.patch>
> >
> > I don't see how this matches together with the RFC you quote.
> > You skip encoding of ? and = for example, but you %-encode # and & which
> > are in the same class of characters respectively.
> >
> After going through the RFC once again, I realized that I have missed the
> sub-delims characters from here:
> http://tools.ietf.org/html/rfc3986#section-2.2
> Fixed it now.  Please review it.
> 
> Thanks,
> Senthil

>  utils.c |   51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 5e1fd1fdf7a632aec680b606db7a97efee7047b9  special-characters-in-URL.patch
> From 6b185c8a0be9af6ffcdfc400365e7cc2bf4195ba Mon Sep 17 00:00:00 2001
> From: Senthilnathan M <senthilnathan.maadasamy at gmail.com>
> Date: Sun, 10 Feb 2013 23:08:52 +0530
> Subject: [PATCH] Support for special characters in URL.  Fixes ticket 2031.

ive run some tests with this patch and it seems not to break anything
ill leave review to saste & reimar, i dont know the url escaping rules
well enough without reading the RFC ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130316/81aecd9d/attachment.asc>