[FFmpeg-devel] [PATCH] Handling special characters in a URL.

Senthilnathan Maadasamy senthilnathan.maadasamy at gmail.com
Wed Mar 6 20:09:01 CET 2013


On Tue, Mar 5, 2013 at 11:57 AM, Reimar Döffinger
<Reimar.Doeffinger at gmx.de>wrote:

> On 5 Mar 2013, at 05:00, Senthilnathan Maadasamy <
> senthilnathan.maadasamy at gmail.com> wrote:
>
> > On Mon, Mar 4, 2013 at 7:49 PM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >
> >> On Mon, Mar 04, 2013 at 06:30:03AM +0530, Senthilnathan Maadasamy
> wrote:>
> >> +    while (len < component_size && (c = src[len])) {
> >>
> >>> +        if (isalnum(c) || strchr("-._~%", c) ||
> >>
> >> isalnum is locale specific
> >
> > Fixed it in the attached patch.
> > <special-characters-in-URL.patch>
>
> I don't see how this matches together with the RFC you quote.
> You skip encoding of ? and = for example, but you %-encode # and & which
> are in the same class of characters respectively.
>
After going through the RFC once again, I realized that I have missed the
sub-delims characters from here:
http://tools.ietf.org/html/rfc3986#section-2.2
Fixed it now.  Please review it.

Thanks,
Senthil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: special-characters-in-URL.patch
Type: application/octet-stream
Size: 2933 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130307/49be7727/attachment.obj>


More information about the ffmpeg-devel mailing list