[FFmpeg-devel] [PATCH] lavf/mux: Don't write "encoder" metadata tag when bitexact is requested

Carl Eugen Hoyos cehoyos at ag.or.at
Fri Dec 6 10:16:58 CET 2013


Timothy Gu <timothygu99 <at> gmail.com> writes:

> > +    } else {
> > +        av_dict_set(&s->metadata, "encoder", NULL, 0);
> >      }
> 
> Nit: Unnecessary {}

They are actually preferred by our coding style, 
only remove (don't use) them in code maintained 
by you.
The reason is that they reduce diffs in future 
patches (makes them more readable).

Carl Eugen



More information about the ffmpeg-devel mailing list