[FFmpeg-devel] [PATCH] lavf/mux: Don't write "encoder" metadata tag when bitexact is requested

[Clément Bœsch]

On Thu, Dec 05, 2013 at 07:43:37PM -0800, Timothy Gu wrote:
> On Thursday, December 5, 2013, James Almer wrote:
> 
> > Since we don't write lavf's string when bitexact is requested, this will
> > prevent the tag from being copied from the source stream.
> >
> > Signed-off-by: James Almer <jamrial at gmail.com <javascript:;>>
> > ---
> >  libavformat/mux.c           | 2 ++
> >  tests/ref/lavf-fate/ogg_vp3 | 4 ++--
> >  2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavformat/mux.c b/libavformat/mux.c
> > index eff7caa..79625c6 100644
> > --- a/libavformat/mux.c
> > +++ b/libavformat/mux.c
> > @@ -339,6 +339,8 @@ static int init_muxer(AVFormatContext *s, AVDictionary
> > **options)
> >      /* set muxer identification string */
> >      if (s->nb_streams && !(s->streams[0]->codec->flags &
> > CODEC_FLAG_BITEXACT)) {
> >          av_dict_set(&s->metadata, "encoder", LIBAVFORMAT_IDENT, 0);
> > +    } else {
> > +        av_dict_set(&s->metadata, "encoder", NULL, 0);
> >      }
> 
> 
> Nit: Unnecessary {}
> 

They are already here. Let's not suggest pointless bikeshedding and leave
this choice to the coder.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131206/6b30dfb8/attachment.asc>