[FFmpeg-devel] [PATCH] libavcodec: Do not return encoding errors when -sub_charenc_mode is do_nothing
Reimar.Doeffinger at gmx.de
Thu Aug 29 04:45:27 CEST 2013
On 28.08.2013, at 23:41, Nicolas George <nicolas.george at normalesup.org> wrote:
> Le primidi 11 fructidor, an CCXXI, Eelco Lempsink a écrit :
>> Signed-off-by: Eelco Lempsink <eml at tupil.com>
>> libavcodec/utils.c | 15 ++++++++++-----
>> 1 file changed, 10 insertions(+), 5 deletions(-)
> This is not what « do nothing » is meant for. It is meant for situations
> where the muxer already did the job, and the check to ensure that the job
> was done properly is still relevant.
> If you want to bypass the check, please add a dedicated option, and clearly
> document that any application that uses it is misdesigned and will not work
> once the full recoding API is implemented.
Please at least offer people a way to solve their problems without immediately threatening them to "break their program as soon as possible".
I see no reason why a special value to bypass everything would have to stop to work just because an alternative exists and fully works.
More information about the ffmpeg-devel