[FFmpeg-devel] [PATCH] Reduce MAKE_ACCESSORS code duplication via a new header.

Paul B Mahol onemda at gmail.com
Thu Aug 8 23:55:02 CEST 2013


On 8/8/13, James Almer <jamrial at gmail.com> wrote:
> On 08/08/13 3:02 PM, Reimar Doeffinger wrote:
>> ---
>>  libavcodec/utils.c    | 5 +----
>>  libavformat/utils.c   | 5 +----
>>  libavutil/accessors.h | 3 +++
>>  libavutil/frame.c     | 4 +---
>>  4 files changed, 6 insertions(+), 11 deletions(-)
>>  create mode 100644 libavutil/accessors.h
>
> A bit late to the party, but wouldn't it make more sense to add this
> to libavutil/internal.h or some other existing general usage header?
>
> In any case, you should add a copyright header to accessors.h

But than patch would be much bigger.

Switch to one which much less lines.


More information about the ffmpeg-devel mailing list