[FFmpeg-devel] [PATCH] Reduce MAKE_ACCESSORS code duplication via a new header.
Reimar.Doeffinger at gmx.de
Fri Aug 9 06:34:19 CEST 2013
On 08.08.2013, at 23:55, Paul B Mahol <onemda at gmail.com> wrote:
> On 8/8/13, James Almer <jamrial at gmail.com> wrote:
>> On 08/08/13 3:02 PM, Reimar Doeffinger wrote:
>>> libavcodec/utils.c | 5 +----
>>> libavformat/utils.c | 5 +----
>>> libavutil/accessors.h | 3 +++
>>> libavutil/frame.c | 4 +---
>>> 4 files changed, 6 insertions(+), 11 deletions(-)
>>> create mode 100644 libavutil/accessors.h
>> A bit late to the party, but wouldn't it make more sense to add this
>> to libavutil/internal.h or some other existing general usage header?
>> In any case, you should add a copyright header to accessors.h
> But than patch would be much bigger.
> Switch to one which much less lines.
Sorry, I don't know what I was thinking. I'll propose moving it when I have time, if nobody beats me to it.
More information about the ffmpeg-devel