[FFmpeg-devel] [PATCH] xtea: fix CBC mode when src=dst

[Michael Niedermayer]

On Sun, Sep 30, 2012 at 06:59:08PM +0200, Giorgio Vazzana wrote:
> 2012/9/30 Michael Niedermayer <michaelni at gmx.at>:
> > integrated the test code, applied and simplified the patch
> >
> > thanks alot, i had not realized this problem last i looked at the code
> 
> You're welcome. I also just noticed that the test program fails when
> compiling with --enable-small. The attached patch fixes the problem.
> 
> Lastly, a minor thing: with --enable-small I get the following warnings:
> CC	libavutil/xtea.o
> libavutil/xtea.c: In function ‘xtea_crypt_ecb’:
> libavutil/xtea.c:45: warning: unused variable ‘k3’
> libavutil/xtea.c:44: warning: unused variable ‘k2’
> libavutil/xtea.c:43: warning: unused variable ‘k1’
> libavutil/xtea.c:42: warning: unused variable ‘k0’
> 
> Thanks.
> Giorgio Vazzana

>  xtea.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> e263ee65490e29ac9966277b77f2ef678f86116c  0001-xtea-fix-decryption-with-enable-small.patch
> From 59f1ca45dea4d6e0f910df755077a0b09dd29611 Mon Sep 17 00:00:00 2001
> From: Giorgio Vazzana <mywing81 at gmail.com>
> Date: Sun, 30 Sep 2012 18:47:10 +0200
> Subject: [PATCH] xtea: fix decryption with --enable-small
> 
> iv decrypt handling code needs to be executed regardless of CONFIG_SMALL

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120930/e155d2b8/attachment.asc>