[FFmpeg-devel] [PATCH] xtea: fix CBC mode when src=dst

Giorgio Vazzana mywing81 at gmail.com
Sun Sep 30 18:59:08 CEST 2012


2012/9/30 Michael Niedermayer <michaelni at gmx.at>:
> integrated the test code, applied and simplified the patch
>
> thanks alot, i had not realized this problem last i looked at the code

You're welcome. I also just noticed that the test program fails when
compiling with --enable-small. The attached patch fixes the problem.

Lastly, a minor thing: with --enable-small I get the following warnings:
CC	libavutil/xtea.o
libavutil/xtea.c: In function ‘xtea_crypt_ecb’:
libavutil/xtea.c:45: warning: unused variable ‘k3’
libavutil/xtea.c:44: warning: unused variable ‘k2’
libavutil/xtea.c:43: warning: unused variable ‘k1’
libavutil/xtea.c:42: warning: unused variable ‘k0’

Thanks.
Giorgio Vazzana
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xtea-fix-decryption-with-enable-small.patch
Type: application/octet-stream
Size: 923 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120930/8800bf33/attachment.obj>


More information about the ffmpeg-devel mailing list