[FFmpeg-devel] [PATCH] opus encoder using libopus

Sin-ta Hsiea ibmibmibm.tw at gmail.com
Fri Sep 21 08:01:31 CEST 2012


On Thu, 20 Sep 2012 13:48:34 +0200, Nicolas George wrote:
> Thanks for the patch. It looks very similar to the one Nathan Caldwell
> submitted to libav yesterday:
> http://lists.libav.org/pipermail/libav-devel/2012-September/035616.html
> including structures and function names, and some cosmetics changes that
> were applied to libav and not ffmpeg.
> Is there any link between the two patches?
Yes, this patch is based from the patch in the link.

But LIBAVCODEC_VERSION_MINOR in this patch is too old for upstream
version of ffmpeg,
so i made some change for API changed.
Also, i found that opts's lookahead is not fit in avctx->skip, so i
also changed this place.

> Also, I think that the work on the encoder itself is completely original,
> and therefore warrant a copyright attribution to someone who is not me.
But the libopus_enc.c file was wrote by you first, isn't it?
So I think the copyright is belongs to you, and i'm not lawyer.

Best regards,
Sin-ta Hsiea


More information about the ffmpeg-devel mailing list