[FFmpeg-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

Ronald S. Bultje rsbultje at gmail.com
Fri Oct 5 18:48:35 CEST 2012


Hi,

On Oct 5, 2012 8:51 AM, "Michael Niedermayer" <michaelni at gmx.at> wrote:
>
> Hi
>
> On Wed, Oct 03, 2012 at 04:25:14PM -0700, Ronald S. Bultje wrote:
> > From: "Ronald S. Bultje" <rsbultje at gmail.com>
> >
> > The variable is copied to subsequent threads at the same time, so this
> > may cause wrong ref_count[] values to be copied to subsequent threads.
> >
> > This bug was found using TSAN.
> > ---
> >  libavcodec/h264_cabac.c |   41
++++++++++++++++-------------------------
> >  libavcodec/h264_cavlc.c |   33 +++++++++++++--------------------
> >  2 files changed, 29 insertions(+), 45 deletions(-)
>
> It appears different patches where commited to libav and ffmpeg.
> ronald, can you look into fixing that ?
>
> it would make future work harder for everyone if things diverge
> pointlessly

I don't remember posting different patches to either one mailing list
alone. Whoever did should probably rectify this?

Ronald


More information about the ffmpeg-devel mailing list