[FFmpeg-devel] [PATCH] h264: don't touch H264Context->ref_count[] during MB decoding.

Michael Niedermayer michaelni at gmx.at
Fri Oct 5 17:50:22 CEST 2012


Hi

On Wed, Oct 03, 2012 at 04:25:14PM -0700, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <rsbultje at gmail.com>
> 
> The variable is copied to subsequent threads at the same time, so this
> may cause wrong ref_count[] values to be copied to subsequent threads.
> 
> This bug was found using TSAN.
> ---
>  libavcodec/h264_cabac.c |   41 ++++++++++++++++-------------------------
>  libavcodec/h264_cavlc.c |   33 +++++++++++++--------------------
>  2 files changed, 29 insertions(+), 45 deletions(-)

It appears different patches where commited to libav and ffmpeg.
ronald, can you look into fixing that ?

it would make future work harder for everyone if things diverge
pointlessly

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121005/6ef2212d/attachment.asc>


More information about the ffmpeg-devel mailing list