[FFmpeg-devel] [PATCH 1/7] lavfi/tile: allow named arguments.

Alexander Strasser eclipse7 at gmx.net
Sat Nov 10 01:51:29 CET 2012


Hi Clément,

Clément Bœsch wrote:
[...]
> +
> +static const AVOption tile_options[] = {
> +    { "size", "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },
> +    { "s",    "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },

  The name "size" and the description seem misleading to me.

  Suggestion:
  tiles, set layout of tiles

  Would need further adjustment in filters.texi though.

  So IMHO can be fixed in a separate patch after this patch set is pushed.

[...]

  Alexander


More information about the ffmpeg-devel mailing list