[FFmpeg-devel] [PATCH 1/7] lavfi/tile: allow named arguments.

Clément Bœsch ubitux at gmail.com
Sat Nov 10 22:56:19 CET 2012


On Sat, Nov 10, 2012 at 10:43:05PM +0100, Nicolas George wrote:
> Le decadi 20 brumaire, an CCXXI, Clément Bœsch a écrit :
> > The AVOption arrays are one of the very few exceptions where I think
> > breaking the lines really harms the readability a lot. But you are the
> > maintainer of the filter, so be it. Consider it changed locally.
> 
> Thanks. That is not a big deal. The problem with the options arrays is that
> the length of the lines grow as new options are added that need more room in
> various column, up tu the point they become completely unreadable because
> they overflow the width of the editor (-> wrap or scroll).
> 

To me, these arrays are just tabular values, which you read by column:
since a large part of the code is wrapped to 80 columns, you can have a
nowrap option in your editor, and read these values vertically by
scrolling horizontally (or just switch fullscreen the necessary time).

Comparing values vertically is not possible anymore when lines are
manually wrapped (unless you do like me and join all the lines with some
nice editor trick before reading them).

> But do not bother if you do not want to.
> 

I've already changed it, so my feeling are already deeply hurt, I won't
change this back.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121110/f3a2c90a/attachment.asc>


More information about the ffmpeg-devel mailing list