[FFmpeg-devel] [PATCH] sbgdec: dont set slide to a uninitialized value

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Nov 6 22:08:43 CET 2012


On Tue, Nov 06, 2012 at 09:46:20PM +0100, Michael Niedermayer wrote:
> On Tue, Nov 06, 2012 at 09:27:15PM +0100, Nicolas George wrote:
> > Le sextidi 16 brumaire, an CCXXI, Michael Niedermayer a écrit :
> > > Fixed CID703833
> > > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > 
> > I intended to fix this one with:
> > 
> > 	struct sbg_fade f = { 0 };
> > 
> > at the beginning of the same function, as soon as I got time to work on it,
> > but this version works too. Thanks.
> 
> commited your variant then, seems reimar prefers it as well

Not that it matters, but I had thought of
f = *fr;
in order to better match the name and only make it update those two
values. Of course that's only based on a completely unfounded
guess on what the author thought the semantics should be.


More information about the ffmpeg-devel mailing list