[FFmpeg-devel] [PATCH 0/2] RFC: TEXT subtitle decoder

[Clément Bœsch]

On Fri, May 25, 2012 at 09:30:35AM -0700, Philip Langdale wrote:
> On 22.05.2012 22:10, Philip Langdale wrote:
> >Based on the discussion over the last few days, here is an initial
> >pass at a TEXT decoder. It's probably not in a condition to go in
> >directly, as we'd probably want to rename srtdec to textdec, and
> >someone's going to want me to modify the SRT demuxer to emit this
> >TEXT format rather than raw SRT packets (which I don't really mind
> >but I'd rather not hold up the decoder on redoing the demuxer)
> >
> >Philip Langdale (2):
> >  matroskadec: Write duration into packet for TEXT subtitles.
> >  srtdec: Add TEXT subtitle decoding mode.
> >
> > libavcodec/allcodecs.c    |    1 +
> > libavcodec/srtdec.c       |   25 ++++++++++++++++++++++---
> > libavformat/matroskadec.c |    2 +-
> > 3 files changed, 24 insertions(+), 4 deletions(-)
> 
> Would anybody like to comment?
> 

Why do you hack into srtdec? srt is a SubRip format, and AFAIK is not
related at all to TEXT (TTXT?). Shouldn't you instead write a new
lavc/ttxtdec.c (which can be reused into mov/mp4 as well)?

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120525/a527b66e/attachment.asc>