[FFmpeg-devel] [PATCH 0/2] RFC: TEXT subtitle decoder

[Philip Langdale]

On 22.05.2012 22:10, Philip Langdale wrote:
> Based on the discussion over the last few days, here is an initial
> pass at a TEXT decoder. It's probably not in a condition to go in
> directly, as we'd probably want to rename srtdec to textdec, and
> someone's going to want me to modify the SRT demuxer to emit this
> TEXT format rather than raw SRT packets (which I don't really mind
> but I'd rather not hold up the decoder on redoing the demuxer)
>
> Philip Langdale (2):
>   matroskadec: Write duration into packet for TEXT subtitles.
>   srtdec: Add TEXT subtitle decoding mode.
>
>  libavcodec/allcodecs.c    |    1 +
>  libavcodec/srtdec.c       |   25 ++++++++++++++++++++++---
>  libavformat/matroskadec.c |    2 +-
>  3 files changed, 24 insertions(+), 4 deletions(-)

Would anybody like to comment?

My overall goal here is to get MPEG4 Part 17 subtitle support into
ffmpeg, and particularly, get to a point where you can remux an mkv
file into an mp4 one and transfer all the important content (hence
my other patch to fix chapter handling in mp4). Even with a working
subtitle encoder, we still need to be able to extract the subtitles
from the source file in the first place, which doesn't work without
this set of patches.

I'm aware of all the other discussion around overall subtitle handling
(and I'll note that we already 'up-convert' to ASS internally, so I'm
not sure why that's being discussed like a new thing) but pragmatically
speaking, there's no reason that resolving that wider problem has to 
hold
up all work on subtitles.

When I get a chance, I'm going to push a branch to github with the 
actual
Part17 encoder/decoder; what I've got today works fine but it's still 
too
rough (and no, I won't have style support in the initial cut)

Thanks,

--phil