[FFmpeg-devel] [PATCH 1/3] mp3enc: fix Xing sample rate selection.

[Clément Bœsch]

On Fri, May 11, 2012 at 10:49:15AM +0200, Michael Niedermayer wrote:
> On Fri, May 11, 2012 at 08:40:10AM +0200, Clément Bœsch wrote:
> > On Thu, May 10, 2012 at 07:06:00PM +0200, Michael Niedermayer wrote:
> > > On Wed, May 09, 2012 at 10:41:18PM +0200, Clément Bœsch wrote:
> > > > On Tue, Mar 20, 2012 at 07:22:58PM +0100, Michael Niedermayer wrote:
> > > > > On Tue, Mar 20, 2012 at 04:38:12PM +0100, Clément Bœsch wrote:
> > > > > > From: Clément Bœsch <clement.boesch at smartjog.com>
> [...]
> > > 
> > > > 
> > > > Any idea how I could check if the rest of the header is correctly set?
> > > 
> > > i guess try some things that can read mp3 and see if adding the xing
> > > header causes a difference in their output
> > > 
> > 
> > I've pass a mpck on all the files, and the reports seem OK. Though, this
> > tool doesn't seem to look for a specific Xing header.
> > 
> > If I see no other comment I'll push this in the next days.
> 
> It should be tested that the output does not change
> that is the PCM output from a known to be working decoder
> a change in the first mp3 frames or a change in length by 1 mp3 frame
> would indicate a problem.
> 

I ran a framecrc between the xing and noxing outputs and it revealed no
abnormalities. I also did a diff between s16le outputs, no differences.
Comparing af showinfo outputs showed no particular differences (except the
shifted pos because of the Xing frame not being present).

Thus, pushed.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120513/3aaec288/attachment.asc>