[FFmpeg-devel] [PATCH 1/3] mp3enc: fix Xing sample rate selection.

[Michael Niedermayer]

On Fri, May 11, 2012 at 08:40:10AM +0200, Clément Bœsch wrote:
> On Thu, May 10, 2012 at 07:06:00PM +0200, Michael Niedermayer wrote:
> > On Wed, May 09, 2012 at 10:41:18PM +0200, Clément Bœsch wrote:
> > > On Tue, Mar 20, 2012 at 07:22:58PM +0100, Michael Niedermayer wrote:
> > > > On Tue, Mar 20, 2012 at 04:38:12PM +0100, Clément Bœsch wrote:
> > > > > From: Clément Bœsch <clement.boesch at smartjog.com>
[...]
> > 
> > > 
> > > Any idea how I could check if the rest of the header is correctly set?
> > 
> > i guess try some things that can read mp3 and see if adding the xing
> > header causes a difference in their output
> > 
> 
> I've pass a mpck on all the files, and the reports seem OK. Though, this
> tool doesn't seem to look for a specific Xing header.
> 
> If I see no other comment I'll push this in the next days.

It should be tested that the output does not change
that is the PCM output from a known to be working decoder
a change in the first mp3 frames or a change in length by 1 mp3 frame
would indicate a problem.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120511/68329ec0/attachment.asc>