[FFmpeg-devel] [PATCH 3/3] ffmpeg: support audio in complex filters

Nicolas George nicolas.george at normalesup.org
Mon May 7 18:27:11 CEST 2012


Le nonidi 19 floréal, an CCXX, Matthieu Bouron a écrit :
> The solution i provided in previous mail with missing patch introduce two new
> functions in ffmpeg.c:
>   graph_prepend_filter,
>   graph_create_buffer_filter wich is basically the same as
>   avfilter_graph_create_filter but use graph_preprend_filter.
> 
> IMO this has the advantage to be local to ffmpeg but duplicates codes from
> avfilter. Maybe it's better to provide a patch to avfiltergraph and insert
> filter with no input at begin of the array ?

I saw it, and you summarize the differences pretty well.

I am personally rather for the solution of modifying
avfilter_graph_add_filter, because that makes less total code and separate
patches, an possibly useful for other situations. But maybe I am biased
because I suggested it. So better wait other advices.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120507/7c8aa8df/attachment.asc>


More information about the ffmpeg-devel mailing list