[FFmpeg-devel] [PATCH 3/3] ffmpeg: support audio in complex filters
Matthieu Bouron
matthieu.bouron at gmail.com
Mon May 7 16:23:35 CEST 2012
On Mon, May 07, 2012 at 02:44:35PM +0200, Nicolas George wrote:
> Le nonidi 19 floréal, an CCXX, Matthieu Bouron a écrit :
> > Patch updated with first solution.
>
> Patch forgotten.
>
> I did not understand your suggestion. The obvious quick solution would be,
> in avfilter_graph_add_filter, if the filter has no inputs
> (filter->input_count == 0), insert it at the beginning instead of the end.
> This is somewhat inefficient, but that probably does not matter much (and
> the implementation with a realloc of n+1 each time is very inefficient too).
>
> Also, note that this is a separate issue than changing ffmpeg to support
> audio filters.
The solution i provided in previous mail with missing patch introduce two new
functions in ffmpeg.c:
graph_prepend_filter,
graph_create_buffer_filter wich is basically the same as
avfilter_graph_create_filter but use graph_preprend_filter.
IMO this has the advantage to be local to ffmpeg but duplicates codes from
avfilter. Maybe it's better to provide a patch to avfiltergraph and insert
filter with no input at begin of the array ?
Regards,
Matthieu
More information about the ffmpeg-devel
mailing list