[FFmpeg-devel] [PATCH] pthreads: Generic progress lubrication support.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Jan 23 22:56:42 CET 2012



On 23 Jan 2012, at 22:40, Michael Niedermayer <michaelni at gmx.at> wrote:
>> There is also the simpler alternative I had in mind originally:
>> Always complain when the progress is not INT_MAX at the end, simply
>> defining that to always be the final value.
> 
> I still dont understand where the point is in duplicating the progress
> update in every exit path of every decoder
> that is not "less buggy" that is "more fragile" because it will be
> forgotten every time a new value is checked and a new return -1 is
> added

Is that the only issue it is really supposed to fix?
I had assumed it was meant to fix all kinds of various issue with various causes.
If so I'd change my assessment instead to "I think we have a few unnecessary process updates lying around".


More information about the ffmpeg-devel mailing list