[FFmpeg-devel] [PATCH] pthreads: Generic progress lubrication support.

[Michael Niedermayer]

On Mon, Jan 23, 2012 at 10:56:42PM +0100, Reimar Döffinger wrote:
> 
> 
> On 23 Jan 2012, at 22:40, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> There is also the simpler alternative I had in mind originally:
> >> Always complain when the progress is not INT_MAX at the end, simply
> >> defining that to always be the final value.
> > 
> > I still dont understand where the point is in duplicating the progress
> > update in every exit path of every decoder
> > that is not "less buggy" that is "more fragile" because it will be
> > forgotten every time a new value is checked and a new return -1 is
> > added
> 
> Is that the only issue it is really supposed to fix?

yes, but of course i dont know if there are things it hides.
I definitly consider it a bug if a fully successfully decoded frame
doesnt update the progresses to the max

also all issues iam aware of are with fuzzed files


> I had assumed it was meant to fix all kinds of various issue with various causes.
> If so I'd change my assessment instead to "I think we have a few unnecessary process updates lying around".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120124/a8dd684a/attachment.asc>