[FFmpeg-devel] [PATCH] af_pan: comment a tricky piece of code.

Nicolas George nicolas.george at normalesup.org
Wed Feb 15 19:58:02 CET 2012

Le septidi 27 pluviôse, an CCXX, Clément Bœsch a écrit :
> Actually, I wouldn't mind a few logical blocks comments in a few cases,
> even if relatively obvious.

I'll see what I can do.

> > +        /* channel_id <- first set bit in layout */
> Couldn't you just say "the first bit set in layout defines channel_id"?

I find "defines" less clear and accurate.

Another possibility would be to add av_find_first_bit_set to avutil and
write "channel_id = av_find_first_bit_set(layout)": obvious and

Or we could use ffs, but it is an XSI extension (so: no idea if it will be
available in crappy build environments) and the name is awful.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120215/adf17674/attachment.asc>

More information about the ffmpeg-devel mailing list