[FFmpeg-devel] [PATCH] af_pan: comment a tricky piece of code.

Clément Bœsch ubitux at gmail.com
Wed Feb 15 20:10:52 CET 2012


On Wed, Feb 15, 2012 at 07:58:02PM +0100, Nicolas George wrote:
> Le septidi 27 pluviôse, an CCXX, Clément Bœsch a écrit :
> > Actually, I wouldn't mind a few logical blocks comments in a few cases,
> > even if relatively obvious.
> 
> I'll see what I can do.
> 
> > > +        /* channel_id <- first set bit in layout */
> > Couldn't you just say "the first bit set in layout defines channel_id"?
> 
> I find "defines" less clear and accurate.
> 

Commit whatever you believe makes more sense; I just think a full sentence
would be more appropriate.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120215/41ad076b/attachment.asc>


More information about the ffmpeg-devel mailing list