[FFmpeg-devel] [PATCH] ffplay: avoid SDL_atoi()

[Michael Niedermayer]

On Sun, Aug 12, 2012 at 07:49:28PM +0200, Marton Balint wrote:
> 
> 
> On Sat, 11 Aug 2012, Michael Niedermayer wrote:
> 
> >On Sat, Aug 11, 2012 at 10:55:53AM +0200, Stefano Sabatini wrote:
> >>On date Friday 2012-08-10 16:04:59 +0200, Michael Niedermayer encoded:
> >>>It appears this function is not available everywhere
> >>>Should fix Ticket1525
> >>>
> >>>Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >>>---
> >>> ffplay.c |    2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/ffplay.c b/ffplay.c
> >>>index 598ce74..282d56f 100644
> >>>--- a/ffplay.c
> >>>+++ b/ffplay.c
> >>>@@ -2098,7 +2098,7 @@ static int audio_open(void *opaque, int64_t wanted_channel_layout, int wanted_nb
> >>>
> >>>     env = SDL_getenv("SDL_AUDIO_CHANNELS");
> >>>     if (env) {
> >>>-        wanted_nb_channels = SDL_atoi(env);
> >>>+        wanted_nb_channels = atoi(env);
> >>
> >>Looks good to me (I wonder why SDL_atoi() was used in the first
> >>place).
> >
> >Cc-ing marton, its probably better if he comments before this is
> >pushed as i do not know why SDL_atio() even exists, so i could be
> >missing something ...
> 
> LGTM, sorry for the delay.

ok, applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120812/8330845f/attachment.asc>