[FFmpeg-devel] [PATCH] mxfenc: audio only support

[Michael Niedermayer]

On Mon, Apr 02, 2012 at 02:01:18AM +0200, Tomas Härdin wrote:
> On Sun, 2012-04-01 at 21:36 +0200, Michael Niedermayer wrote:
> > @@ -1467,6 +1460,10 @@ static int mxf_write_header(AVFormatContext *s)
> >                  return -1;
> >              }
> >              avpriv_set_pts_info(st, 64, 1, st->codec->sample_rate);
> > +            if (!mxf->time_base.num) {
> > +                mxf->time_base = (AVRational){ 1, st->codec->sample_rate };
> > +                rate = (AVRational){ 30, 1 };
> > +            }
> 
> mxf->time_base is EditRate (or rather, its inverse) - I wouldn't
> recommend setting it to the sample rate. I'm not entirely into how the
> interleaving works, but I suspect this would result in each *sample*
> being muxed as its own KLV packet + system item; a mere ~2000-3000%
> overhead :)

overhead doesnt change when i set this to 30 or 48000


> 
> Doesn't code elsewhere in mxfenc default to 25 fps / 1920 samples/frame?
> If so then I think this should should too. Like:
> 
> mxf->time_base = (AVRational){ 1, 25 };
> rate = (AVRational){ 25, 1 };

any other changes i should do or its ok with just that ?

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120402/a4234796/attachment.asc>