[FFmpeg-devel] [PATCH] mxfenc: audio only support

[Tomas Härdin]

On Sun, 2012-04-01 at 21:36 +0200, Michael Niedermayer wrote:
> @@ -1467,6 +1460,10 @@ static int mxf_write_header(AVFormatContext *s)
>                  return -1;
>              }
>              avpriv_set_pts_info(st, 64, 1, st->codec->sample_rate);
> +            if (!mxf->time_base.num) {
> +                mxf->time_base = (AVRational){ 1, st->codec->sample_rate };
> +                rate = (AVRational){ 30, 1 };
> +            }

mxf->time_base is EditRate (or rather, its inverse) - I wouldn't
recommend setting it to the sample rate. I'm not entirely into how the
interleaving works, but I suspect this would result in each *sample*
being muxed as its own KLV packet + system item; a mere ~2000-3000%
overhead :)

Doesn't code elsewhere in mxfenc default to 25 fps / 1920 samples/frame?
If so then I think this should should too. Like:

mxf->time_base = (AVRational){ 1, 25 };
rate = (AVRational){ 25, 1 };

/Tomas