[FFmpeg-devel] [PATCH]Silence a warning if pkg_config is not available

[Michael Niedermayer]

On Mon, May 09, 2011 at 04:47:05PM -0700, Baptiste Coudurier wrote:
> On 5/4/11 4:11 PM, Stefano Sabatini wrote:
> > On date Wednesday 2011-05-04 15:27:13 -0700, Baptiste Coudurier encoded:
> >> On 05/04/2011 03:10 PM, Stefano Sabatini wrote:
> >>> On date Wednesday 2011-05-04 08:25:40 -0700, Baptiste Coudurier encoded:
> >>>> On 05/04/2011 06:27 AM, Michael Niedermayer wrote:
> >>>>> On Mon, May 02, 2011 at 04:07:32PM -0700, Baptiste Coudurier wrote:
> >>>>>> On 05/02/2011 03:57 PM, Carl Eugen Hoyos wrote:
> >>>>>>> Hi!
> >>>>>>>
> >>>>>>> Attached patch silences a warning if configure is run on a system where 
> >>>>>>> pkg_config is not installed.
> >>>>>>>
> >>>>>>
> >>>>>> Thanks !
> >>>>>> FYI SDL detection is broken on OSX because of the change to pkg-config.
> >>>>>
> >>>>> could you elaborate? i dont have osx and am not sure what "the change"
> >>>>> is, do you mean the
> >>>>> configure: use pkg-config helpers
> >>>>> or
> >>>>> configure: improve pkg-config support
> >>>>> or both or something else?
> >>>>
> >>>> The commit that change SDL detection to use pkg-config instead of
> >>>> sdl-config.
> >>>
> >>> Why? Doesn't OSX support pkg-config? Or is the SDL version installed
> >>> which doesn't support it (but only supports sdl-config)?
> >>>
> >>> In general using pkg-config when available is preferred over
> >>> foo-config.
> >>
> >> pkg-config is not present on OSX, and difficult to install, requiring
> >> it for SDL is not needed. If there is pkg-config, fine, but if not use
> >> sdl-config.
> > 
> > If installing pkg-config on OSX is problematic I'm not against
> > reverting that hunk.
> 
> Yes, I think that hunk should be reverted until a better solution is
> implemented, which is to fallback on sdl-config if pkg-config is not
> present.

done locally, will push

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110510/d6c5a702/attachment.asc>