[FFmpeg-devel] [PATCH]Silence a warning if pkg_config is not available

[Baptiste Coudurier]

On 5/4/11 4:11 PM, Stefano Sabatini wrote:
> On date Wednesday 2011-05-04 15:27:13 -0700, Baptiste Coudurier encoded:
>> On 05/04/2011 03:10 PM, Stefano Sabatini wrote:
>>> On date Wednesday 2011-05-04 08:25:40 -0700, Baptiste Coudurier encoded:
>>>> On 05/04/2011 06:27 AM, Michael Niedermayer wrote:
>>>>> On Mon, May 02, 2011 at 04:07:32PM -0700, Baptiste Coudurier wrote:
>>>>>> On 05/02/2011 03:57 PM, Carl Eugen Hoyos wrote:
>>>>>>> Hi!
>>>>>>>
>>>>>>> Attached patch silences a warning if configure is run on a system where 
>>>>>>> pkg_config is not installed.
>>>>>>>
>>>>>>
>>>>>> Thanks !
>>>>>> FYI SDL detection is broken on OSX because of the change to pkg-config.
>>>>>
>>>>> could you elaborate? i dont have osx and am not sure what "the change"
>>>>> is, do you mean the
>>>>> configure: use pkg-config helpers
>>>>> or
>>>>> configure: improve pkg-config support
>>>>> or both or something else?
>>>>
>>>> The commit that change SDL detection to use pkg-config instead of
>>>> sdl-config.
>>>
>>> Why? Doesn't OSX support pkg-config? Or is the SDL version installed
>>> which doesn't support it (but only supports sdl-config)?
>>>
>>> In general using pkg-config when available is preferred over
>>> foo-config.
>>
>> pkg-config is not present on OSX, and difficult to install, requiring
>> it for SDL is not needed. If there is pkg-config, fine, but if not use
>> sdl-config.
> 
> If installing pkg-config on OSX is problematic I'm not against
> reverting that hunk.

Yes, I think that hunk should be reverted until a better solution is
implemented, which is to fallback on sdl-config if pkg-config is not
present.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org