[FFmpeg-devel] [PATCH] lavfi: add vsink_buffer, and use it in ff* tools

Stefano Sabatini stefano.sabatini-lala at poste.it
Tue Jun 14 13:32:21 CEST 2011


On date Monday 2011-06-13 00:27:39 +0200, Stefano Sabatini encoded:
> On date Sunday 2011-06-12 17:32:37 +0200, Michael Niedermayer encoded:
[...]
> Not pushed, there is a small leak problem (when uniting the sink
> inlink->cur_buf may still contain a picref, but inlink was already
> freed. So we need either to unref the picref when freeing the link, or
> cache the picref in the sink context, so we can free it in uninit) but
> I'm too tired now to decide which is the better solution.
> 
> Patch updated with docs.

I'm caching the picref in the sink itself, I'm keeping just one frame
for the moment, this could be improved by increasing the size of the
cache (which is even required by some scenario, e.g. with a split
filter).

Check attached patch.
-- 
FFmpeg = Fierce & Funny Murdering Programmable Experimenting Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-add-vsink_buffer-and-use-it-in-ff-tools.patch
Type: text/x-diff
Size: 17654 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110614/12785fbd/attachment.bin>


More information about the ffmpeg-devel mailing list