[FFmpeg-devel] [PATCH] lavfi: add vsink_buffer, and use it in ff* tools

Michael Niedermayer michaelni at gmx.at
Wed Jun 15 05:15:40 CEST 2011

On Tue, Jun 14, 2011 at 01:32:21PM +0200, Stefano Sabatini wrote:
> On date Monday 2011-06-13 00:27:39 +0200, Stefano Sabatini encoded:
> > On date Sunday 2011-06-12 17:32:37 +0200, Michael Niedermayer encoded:
> [...]
> > Not pushed, there is a small leak problem (when uniting the sink
> > inlink->cur_buf may still contain a picref, but inlink was already
> > freed. So we need either to unref the picref when freeing the link, or
> > cache the picref in the sink context, so we can free it in uninit) but
> > I'm too tired now to decide which is the better solution.
> > 
> > Patch updated with docs.
> I'm caching the picref in the sink itself, I'm keeping just one frame
> for the moment, this could be improved by increasing the size of the
> cache (which is even required by some scenario, e.g. with a split
> filter).
> Check attached patch.

ive not had the time to fully review this but if it works and adds
no new limitations then it should be ok


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110615/315da3e2/attachment.asc>

More information about the ffmpeg-devel mailing list