[FFmpeg-devel] [PATCH] Implement AAC Long Term Prediction (LTP) decoding module

Diego Biurrun diego
Sun Jan 30 01:37:22 CET 2011


On Sun, Jan 30, 2011 at 08:53:54AM +0900, Young Han Lee wrote:
> 
> Thank you for comments.
> I update the patch following the style.
> If you find any mistakes again, please let me know to fix them

Get rid of the tabs and the trailing whitespace please.

> --- a/libavcodec/aac.h
> +++ b/libavcodec/aac.h
> @@ -629,6 +631,24 @@ static int decode_prediction(AACContext *ac, IndividualChannelStream *ics,
>  
> +static void decode_ltp(AACContext *ac, LongTermPrediction *ltp, 
> +                       GetBitContext *gb, uint8_t max_sfb) 
> +{
> +    int sfb;
> +    if (ac->m4ac.object_type == AOT_ER_AAC_LD) {
> +        av_log(ac->avctx, AV_LOG_ERROR, "LTP is not supported in ER AAC LD .\n");
> +        } else {

Indentation is off here.

> +static void windowing_and_mdct_ltp(AACContext * ac, float * out, 
> +                                   float * in, IndividualChannelStream * ics) 

*ac, *out, *in, *ics

K&R style pastes the pointer stars onto the variables, see the rest
of the file.

Diego



More information about the ffmpeg-devel mailing list