[FFmpeg-devel] [PATCH] Implement AAC Long Term Prediction (LTP) decoding module

[beckgom]

On Sun, Jan 30, 2011 at 9:37 AM, Diego Biurrun <diego at biurrun.de> wrote:

> On Sun, Jan 30, 2011 at 08:53:54AM +0900, Young Han Lee wrote:
> >
> > Thank you for comments.
> > I update the patch following the style.
> > If you find any mistakes again, please let me know to fix them
>
> Get rid of the tabs and the trailing whitespace please.
>
> > --- a/libavcodec/aac.h
> > +++ b/libavcodec/aac.h
> > @@ -629,6 +631,24 @@ static int decode_prediction(AACContext *ac,
> IndividualChannelStream *ics,
> >
> > +static void decode_ltp(AACContext *ac, LongTermPrediction *ltp,
> > +                       GetBitContext *gb, uint8_t max_sfb)
> > +{
> > +    int sfb;
> > +    if (ac->m4ac.object_type == AOT_ER_AAC_LD) {
> > +        av_log(ac->avctx, AV_LOG_ERROR, "LTP is not supported in ER AAC
> LD .\n");
> > +        } else {
>
> Indentation is off here.
>
> > +static void windowing_and_mdct_ltp(AACContext * ac, float * out,
> > +                                   float * in, IndividualChannelStream *
> ics)
>
> *ac, *out, *in, *ics
>
> K&R style pastes the pointer stars onto the variables, see the rest
> of the file.
>
> Diego
>

I'm so sorry about that, and thank you for your check.
I update the patch.

I hope it's okay now.

Young Han

PS. lu's reply mades it easier. Thanks a lot.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel at mplayerhq.hu
https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: AAC_DEC_LTP-003.patch
Type: text/x-patch
Size: 13995 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110130/4756a704/attachment.bin>