[FFmpeg-devel] [PATCH] lavfi: add amerge audio filter.

Nicolas George nicolas.george at normalesup.org
Sat Dec 31 16:35:31 CET 2011

Le primidi 11 nivôse, an CCXX, Stefano Sabatini a écrit :
> nit+++: missing point and empty line after short description,
> unnecessary point at the end of @param nb_in_ch

Fixed, and also fixed @aram -> @param.

> nit++: inq


> I wonder if we should make this queue size dynamic.

On one hand, a lot of filters have that kind of queue: amerge, astreamsync,
fifo. A common implementation would probably make things easier.

On the other hand, maybe there should be no need for such queues: in simple
filtergraphs, frames should arrive when they are requested, and in complex
graphs, the fifo filters are there to put things in order, and queueing
frames everywhere may make debugging problems harder.

So I do not really know. I guess this is a matter of policy.

> Looks good to me otherwise.

Thanks. Pushed with a minor bump.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111231/d34c4604/attachment.asc>

More information about the ffmpeg-devel mailing list