[FFmpeg-devel] [PATCH 1/2] lavfi: add astreamsync audio filter.
nicolas.george at normalesup.org
Sat Dec 24 18:02:20 CET 2011
Le quartidi 4 nivôse, an CCXX, Stefano Sabatini a écrit :
> not needed?
Indeed. Neither were the next two ones.
> please provide some comment, or it will harder to read/understand this
> maybe note that this is a bitmap, one bit for each input
> pad/link (maybe using an array instead may help readability)
> > + for (i = 0; i < 42; i++)
> > + av_expr_eval(as->expr, as->var_values, NULL); /* exercize prng */
The first value returned by random(1) seems to be always 0. That does not
look really random.
> nit: qid for making it more clear that id refers a queue (pad_id ->
> pid or link_id -> lid would be fine as well)
> *queue = as->queue[id];
> should ease readability:
Good idea, done.
> circular buffer overflow? shouldn't you check that the buffer is not
> already filled (and in that case maybe release memory)?
That is not necessary: just after this code, which is the only place where
the queue grows, there is a call to send_next, and send_next always ensure
that the buffer is not full.
> Nit: missing final dot.
Also, config_output was not doing its job, neither was it in amerge: that is
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel