[FFmpeg-devel] [PATCH 2/3] flvdec: Disable metadatacreator "MEGA" hack

[Michael Niedermayer]

On Thu, Dec 29, 2011 at 07:51:14PM -0500, Derek Buitenhuis wrote:
> On 29/12/2011 7:38 PM, Michael Niedermayer wrote:
> >Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >---
> > libavformat/flvdec.c |   12 ------------
> > 1 files changed, 0 insertions(+), 12 deletions(-)
> 
> [...]
> 
> >-    AVDictionaryEntry *creator = av_dict_get(s->metadata, "metadatacreator",
> >-                                             NULL, 0);
> >-
> >-    if (creator && !strcmp(creator->value, "MEGA")) {
> >-        /* Files with this metadatacreator tag seem to have filepositions
> >-         * pointing at the 4 trailer bytes of the previous packet,
> >-         * which isn't the norm (nor what we expect here, nor what
> >-         * jwplayer + lighttpd expect, nor what flvtool2 produces).
> >-         * Just ignore the index in this case, instead of risking trying
> >-         * to adjust it to something that might or might not work. */
> >-        return 0;
> >-    }
> 
> What's the motivation for disabling this, and does it bust anything?

Its better to check the index for being valid than have special cases
based on the "metadatacreator"
Thats even more so as ive seen many files with different
metadatacreator that have broken indexes


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111230/573a7079/attachment.asc>