[FFmpeg-devel] [PATCH 2/3] flvdec: Disable metadatacreator "MEGA" hack

[Derek Buitenhuis]

On 29/12/2011 7:38 PM, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  libavformat/flvdec.c |   12 ------------
>  1 files changed, 0 insertions(+), 12 deletions(-)

[...]

> -    AVDictionaryEntry *creator = av_dict_get(s->metadata, "metadatacreator",
> -                                             NULL, 0);
> -
> -    if (creator && !strcmp(creator->value, "MEGA")) {
> -        /* Files with this metadatacreator tag seem to have filepositions
> -         * pointing at the 4 trailer bytes of the previous packet,
> -         * which isn't the norm (nor what we expect here, nor what
> -         * jwplayer + lighttpd expect, nor what flvtool2 produces).
> -         * Just ignore the index in this case, instead of risking trying
> -         * to adjust it to something that might or might not work. */
> -        return 0;
> -    }

What's the motivation for disabling this, and does it bust anything?

- Derek