[FFmpeg-devel] [PATCH] libavformat: Segfault on Apple HTTP Livestream playlist with unavailable hosts

[Michael Niedermayer]

On Wed, Dec 14, 2011 at 06:02:56PM +0100, Takis Issaris wrote:
> 2011/12/14 Nicolas George <nicolas.george at normalesup.org>:
> > Le quartidi 24 frimaire, an CCXX, Michael Niedermayer a écrit :
> >> to me it looks convenient to just be able to call close/free without
> >> needing to protect each call with checks. That is rather have the
> >> checks inside the free/close function
> >
> > That is quite reasonable, indeed, and that is consistent with free for
> > example.
> >
> > OTOH, obviously free_variant_list was doing something wrong, and it may be
> > useful that someone who knows that stuff looks at it more carefully, because
> > the change you just committed may be just hiding the real problem.
>
> I agree that in fact applehttp.c was and still is actually doing
> something wrong for convenience: Namely, it is always invoking the
> same cleanup function on failure, and in one specific case that fails
> as it falsely assumed that you can close an AVFormatContext if the
> context had only been allocated.

If either of you knows of a bug, please report it. Iam happy to fix
it.

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20111214/627ce1aa/attachment.asc>