[FFmpeg-devel] [PATCH] libavformat: Segfault on Apple HTTP Livestream playlist with unavailable hosts

[Takis Issaris]

2011/12/14 Nicolas George <nicolas.george at normalesup.org>:
> Le quartidi 24 frimaire, an CCXX, Michael Niedermayer a écrit :
>> to me it looks convenient to just be able to call close/free without
>> needing to protect each call with checks. That is rather have the
>> checks inside the free/close function
>
> That is quite reasonable, indeed, and that is consistent with free for
> example.
>
> OTOH, obviously free_variant_list was doing something wrong, and it may be
> useful that someone who knows that stuff looks at it more carefully, because
> the change you just committed may be just hiding the real problem.

I agree that in fact applehttp.c was and still is actually doing
something wrong for convenience: Namely, it is always invoking the
same cleanup function on failure, and in one specific case that fails
as it falsely assumed that you can close an AVFormatContext if the
context had only been allocated.


Met vriendelijke groeten,
Takis