[FFmpeg-devel] [PATCH] AMR-WB Decoder

Vitor Sessak vitor1001
Mon Sep 20 11:21:53 CEST 2010

On 09/20/2010 09:09 AM, Diego Biurrun wrote:
> On Sun, Sep 19, 2010 at 11:25:17PM +0200, Vitor Sessak wrote:
>> On 09/19/2010 10:54 PM, Diego Biurrun wrote:
>>> On Fri, Sep 17, 2010 at 05:15:26PM -0300, Marcelo Galv?o P?voa wrote:
>>>> The code has already been reviewed mostly by Vitor Sessak, discussed
>>>> and tested at the ffmpeg-soc list.
>>> Then why does this patch not even follow everything listed in the
>>> New codecs or formats checklist:
>>> http://www.ffmpeg.org/developer.html#SEC7
>>> Vitor?
>> I saw a couple of things that didn't followed the guidelines, but I
>> focused on other more important things (code duplication, mostly) and
>> forgot to point out the nits later.
> BTW, sorry if I sound like I'm picking on you in particular, this has
> been an issue with our SoC processes basically since day one.  Anyway..
> IMNSHO patches should be cooked into shape on ffmpeg-soc before they
> are proposed here.

I think this patch is in a very good shape (much better than the average 
patch posted to -devel), and that's the reason I *explicitly* asked 
Marcelo to post it here. I don't think a couple of nits proves me wrong.


More information about the ffmpeg-devel mailing list