[FFmpeg-devel] [PATCH] AMR-WB Decoder

[Diego Biurrun]

On Sun, Sep 19, 2010 at 11:25:17PM +0200, Vitor Sessak wrote:
> On 09/19/2010 10:54 PM, Diego Biurrun wrote:
>> On Fri, Sep 17, 2010 at 05:15:26PM -0300, Marcelo Galv?o P?voa wrote:
>>>
>>> The code has already been reviewed mostly by Vitor Sessak, discussed
>>> and tested at the ffmpeg-soc list.
>>
>> Then why does this patch not even follow everything listed in the
>> New codecs or formats checklist:
>>
>> http://www.ffmpeg.org/developer.html#SEC7
>>
>> Vitor?
>
> I saw a couple of things that didn't followed the guidelines, but I  
> focused on other more important things (code duplication, mostly) and  
> forgot to point out the nits later.

BTW, sorry if I sound like I'm picking on you in particular, this has
been an issue with our SoC processes basically since day one.  Anyway..

IMNSHO patches should be cooked into shape on ffmpeg-soc before they
are proposed here.  Reviewer time on ffmpeg-devel is in short supply.
SoC students have their private reviewer, the mentor, whose time is
not in equally short supply.

Once a patch has passed review on ffmpeg-soc, nits included, it can be
proposed here and the review process on ffmpeg-devel, where reviewer
time is scarce and precious, will go much faster and smoother.

.. my 2? ..

Diego