[FFmpeg-devel] FW: Allow multiple programs in MPEGTS output stream

[Uve W. Rick]

> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> bounces at mplayerhq.hu] On Behalf Of Carl Eugen Hoyos
> Sent: Wednesday, September 15, 2010 2:34 PM
> To: ffmpeg-devel at mplayerhq.hu
> Subject: Re: [FFmpeg-devel] FW: Allow multiple programs in MPEGTS
> output stream
> 
> Uve W. Rick <Uve.Rick <at> uav.com> writes:
> 
> > Changed ff_program_add_stream to av_program_add_stream.
> >
> > I've also include the entire patch.
> 
> I suspect it was a good idea to send it separately, consider attaching
> multiple
> patches.
> 

Alright I split into three patches: the first one makes program_add_stream_index
global, the send one adds a function to utils.c to find the program structure from
the stream index, and the third one adds program processing to the mpegts encoder.

> [...]
> 
> > +    for(i=0; i<ac->nb_programs; i++)
> > +        program = ac->programs[i];
> > +        for(j=0; j<program->nb_stream_indexes; j++)
> 
> Either a bug or wrong indentation.
> 

Fixed.

> [...]
> 
> > -    service->pmt.opaque = s;
> > -    service->pmt.cc = 15;
> 
> > +        default_service->pmt.opaque = s;
> > +        default_service->pmt.cc = 15;
> 
> Please don't re-indent in a patch that contains functional changes.
> 

The changes moved are not re-indents, the code was put inside of an if-else.

> [...]
> 
> +        if (default_service != NULL)
> +          service = default_service;
> +        else {
> 
> { } missing, please consider using tools/patcheck
> 

Ran patcheck on all files.

> Please fix your line length and cut your quotes, Carl Eugen
> 

I guess outlook does not put in carriage returns, I put them in above.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: av_program.patch
Type: application/octet-stream
Size: 2493 bytes
Desc: av_program.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100915/ff5dc6f0/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: find_program.patch
Type: application/octet-stream
Size: 1480 bytes
Desc: find_program.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100915/ff5dc6f0/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpegtsenc.patch
Type: application/octet-stream
Size: 3737 bytes
Desc: mpegtsenc.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100915/ff5dc6f0/attachment-0002.obj>