[FFmpeg-devel] MPEG TS encoding problem on change from stereo to mono, pay for fix

[Stefano Sabatini]

On date Monday 2010-11-29 13:44:39 +0100, Andreas Unterhuber encoded:
> Any comments about the patch of Stefano Sabatini?
> Would be great - so he can commit the changes. Thanks. 

Plese no top-posting on this list.

> Am 27.11.2010 um 16:54 schrieb Stefano Sabatini:
> 
> > On date Wednesday 2010-11-24 00:10:47 +0100, Stefano Sabatini encoded:
> >> On date Tuesday 2010-11-23 08:19:08 +0100, Reimar D?ffinger encoded:
> >>> On Mon, Nov 22, 2010 at 10:27:37AM +0100, Stefano Sabatini wrote:
> >>>> -    if (ost->audio_resample && !ost->resample) {
> >>>> +    resample_changed = ost->resample_sample_fmt  != dec->sample_fmt ||
> >>>> +                       ost->resample_channels    != dec->channels   ||
> >>>> +                       ost->resample_sample_rate != dec->sample_rate;
> >>>> +
> >>>> +    if (ost->audio_resample && !ost->resample || resample_changed) {
> >>> 
> >>> Doesn't gcc complain with a warning that it wants some extra () here?
> >>> Also I think this is not quite right, at the very least you'll keep
> >>> a resampling context around even if input and output are the same now
> >>> if they weren't before. I'm not sure if it will actually be used, but
> >>> I think it will, too.
> >> 
> >> See your point, updated.

I'm going to apply the patch in a week if I see no comments.
-- 
FFmpeg = Fiendish Frightening Magical Picky Exxagerate Ghost