[FFmpeg-devel] MPEG TS encoding problem on change from stereo to mono, pay for fix

[Andreas Unterhuber]

Any comments about the patch of Stefano Sabatini?
Would be great - so he can commit the changes. Thanks. 

Am 27.11.2010 um 16:54 schrieb Stefano Sabatini:

> On date Wednesday 2010-11-24 00:10:47 +0100, Stefano Sabatini encoded:
>> On date Tuesday 2010-11-23 08:19:08 +0100, Reimar D?ffinger encoded:
>>> On Mon, Nov 22, 2010 at 10:27:37AM +0100, Stefano Sabatini wrote:
>>>> -    if (ost->audio_resample && !ost->resample) {
>>>> +    resample_changed = ost->resample_sample_fmt  != dec->sample_fmt ||
>>>> +                       ost->resample_channels    != dec->channels   ||
>>>> +                       ost->resample_sample_rate != dec->sample_rate;
>>>> +
>>>> +    if (ost->audio_resample && !ost->resample || resample_changed) {
>>> 
>>> Doesn't gcc complain with a warning that it wants some extra () here?
>>> Also I think this is not quite right, at the very least you'll keep
>>> a resampling context around even if input and output are the same now
>>> if they weren't before. I'm not sure if it will actually be used, but
>>> I think it will, too.
>> 
>> See your point, updated.
> 
>> -- 
>> FFmpeg = Frightening & Fantastic Mythic Puristic Easy Gangster
> 
>> From 0bcec33a96f6398d1554ec2199e44b824a1e5bc0 Mon Sep 17 00:00:00 2001
>> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
>> Date: Mon, 22 Nov 2010 01:42:11 +0100
>> Subject: [PATCH] Fix encoding when the input audio format/rate/channels changes during
>> transcoding.
>> 
>> Fix issue #2292.
>> ---
>> ffmpeg.c |   32 ++++++++++++++++++++++++++++++--
>> 1 files changed, 30 insertions(+), 2 deletions(-)
> 
> Ping.
> -- 
> FFmpeg = Fundamentalist Forgiving Moronic Prodigious Elastic Guru
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel